main/python-numpy: make tests depend on parent + checkdepends #3474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hm no, should prolly be all of checkdepends |
z-erica
force-pushed
the
push-xukulxqqupqy
branch
from
0118f18 to
8c26bd3
Compare
z-erica
changed the title
q66
reviewed
Jan 18, 2025
main/python-numpy/template.py
Outdated
| @@ -101,7 +101,10 @@ def post_install(self): | |||
| @subpackage("python-numpy-tests") | |||
| def _(self): | |||
| self.subdesc = "tests" | |||
| self.depends += ["python"] | |||
| self.depends = [ | |||
| *self.parent.checkdepends, | |||
There was a problem hiding this comment.
the reason for this is trying
$ python
Python 3.12.8 (main, Jan 14 2025, 23:43:09) [Clang 19.1.6] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import numpy
>>> numpy.test()
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/usr/lib/python3.12/site-packages/numpy/_pytesttester.py", line 126, in __call__
import pytest
ModuleNotFoundError: No module named 'pytest'
after purposefully installing python-numpy-tests
There was a problem hiding this comment.
no i mean
you can write just checkdepends instead of self.parent.checkdepends
z-erica
force-pushed
the
push-xukulxqqupqy
branch
from
8c26bd3 to
df59ddb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this time for real i prommy