Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

main/playerctl: add user service, adopt #3481

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ttyyls
Copy link
Contributor

@ttyyls ttyyls commented Jan 17, 2025

Description

quoting the manpage

     Playerctl also comes with a daemon called playerctld which keeps track of
     media player activity. When playerctld is running, playerctl commands
     will act on the media player with the most recent activity.  Run the
     command playerctld daemon to start the daemon.

on systemd based distributions the dbus activation is tied to $DISPLAY, although
I don't see why not set it at a login.target since mpris is still usable and
thus potentially controllable on non-graphical environments.

regardless, the service depends on graphical.target and dbus to remain inline
with upstream expectations see:
https://github.com/altdesktop/playerctl#playerctld-autostart-issues

Checklist

  • I have read CONTRIBUTING.md
  • I have read Packaging.md
  • I have built and tested my changes on my machine
  • I will take responsibility for my template and keep it up to date

type = process
command = /usr/bin/playerctld
depends-on = dbus
depends-on = graphical.target
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you sure?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

besides what i previously mentionned in the pr description, i tested it on my machine for a couple of days, and it indeed works.

However i still don't get why the service was supposed to be launched with dbus actvation as a result of a mpris client asking for metadata or a mpris command executed earlier yet neither trigger it for me...

As i understand dbus activation should result in a lingering process (analogous to notification daemons providing org.freedesktop.notifications) but in this case i don't see it, either way it'll be far from the first dbus activated service with a dinit service as well.

so maybe?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants