Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTT Evaulation #962

Merged
merged 3 commits into from
Feb 13, 2025
Merged

NTT Evaulation #962

merged 3 commits into from
Feb 13, 2025

Conversation

sequencer
Copy link
Member

  • [eval] add build
  • [eval] add eval.ntt*

@sequencer
Copy link
Member Author

@Avimitin Please add CI to run all evaluation cases under benchmark_dlen*_vlen* for performance benchmark.

Copy link
Member Author

@sequencer sequencer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should do some thing like this:

  • For ntt_*_main.c it should detect the VLEN at runtime and delegate to different algorithm.
  • For static const int arr[xxx] and its layers, a script should be added to generate those these vector(maybe from ref.ws?) rather than hardcode.
  • Neither do I like gen_data.py, it should also be rewritten into ws for simplicity.
  • How does twiddle get calculated? From gen_vector_ntt_tw.py? I think this python should be rewrite into ws as a function, and codegen corresponding headers.

Please clarify the build stage flows:

  1. Put all user inputs(maybe arr?) into a csv or json file.
  2. At the compile time, a ws should read the csv and generate data and twiddle, the output should be store as json and csv
  3. A codegen python/Scala should read output from ws and generate a corresponding C header file.
  4. The test entry should include the C header file and execute to get the result.

Some random thing I can think about:

  • How do software programmer toggle performance counters though C-API?
  • What's the SW engineer API for benchmark? I think we may need a generic post-evaluation flow for the benchmark.

tests/eval/_ntt/ref.ws Outdated Show resolved Hide resolved
tests/eval/_ntt/ntt_512_main.c Outdated Show resolved Hide resolved
@Lucas-Wye Lucas-Wye force-pushed the ntt branch 7 times, most recently from 54cb9c3 to d16faba Compare February 7, 2025 10:43
@Lucas-Wye Lucas-Wye force-pushed the ntt branch 2 times, most recently from 3fc951e to bc77798 Compare February 13, 2025 02:17
@SharzyL SharzyL merged commit bc48b57 into master Feb 13, 2025
214 checks passed
@SharzyL SharzyL deleted the ntt branch February 13, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants