[wrangler] replace mentions of wrangler.json with wrangler.json(c) #19764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emily-shen
requested review from
migueldemoura,
punkeel,
worenga,
patriciasantaana,
a team,
G4brym,
dcpena,
ToriLindsay,
elithrar,
irvinebroque,
GregBrimble,
WalshyDev,
IgorMinar,
dario-piotrowicz,
jculvey,
mikenomitch,
jasnell,
Oxyjun,
jonesphillip,
maheshwarip,
rts-rob,
sejoker,
vy-ton,
kennyj42,
ranbel,
rita3ko and
daisyfaithauma
as code owners
github-actions
bot
added
product:workers
Deploying cloudflare-docs with
|
| Latest commit: |
dc60a3c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://92f5cdeb.cloudflare-docs-7ou.pages.dev |
| Branch Preview URL: | https://emily-wrangler-jsonc.cloudflare-docs-7ou.pages.dev |
|
Can we pick one and stick to it? (Note: I don't own a product impacted by this and don't have any decision power here :)) |
emily-shen
force-pushed
the
emily/wrangler-jsonc
branch
from
dc60a3c to
d56a916
Compare
|
Preview URL: https://8fa04c10.preview.developers.cloudflare.com Files with changes (up to 15)
|
emily-shen
requested review from
rohinlohe,
angelampcosta,
mchenco and
threepointone
as code owners
Yeah I was trying (somewhat unsuccessfully it seems) to convey that both wrangler.json and wrangler.jsonc would be accepted, but i've just sidestepped the issue by referring to a "Wrangler configuration file" instead :) |
Oxyjun
reviewed
Feb 12, 2025
Oxyjun
approved these changes
Feb 12, 2025
kodster28
approved these changes
Feb 12, 2025
Merged
jonesphillip
pushed a commit
that referenced
this pull request
Feb 12, 2025
…19764) * update references of wrangler.json to wrangler.json(c) * change to wrangler config file with link * Update src/content/partials/workers/secrets-in-dev.mdx --------- Co-authored-by: Jun Lee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
C3 will be outputting wrangler.jsonc instead of plain .json, to reduce user confusion about the comments in wrangler.json.
This is being carried out in this workers-sdk PR: cloudflare/workers-sdk#8024