-
Notifications
You must be signed in to change notification settings - Fork 785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrangler v4 #7334
base: main
Are you sure you want to change the base?
Wrangler v4 #7334
Conversation
🦋 Changeset detectedLatest commit: f6ca096 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13418999425/npm-package-wrangler-7334 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7334/npm-package-wrangler-7334 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13418999425/npm-package-wrangler-7334 dev path/to/script.js Additional artifacts:cloudflare-workers-bindings-extension: wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13418999425/npm-package-cloudflare-workers-bindings-extension-7334 -O ./cloudflare-workers-bindings-extension.0.0.0-ve8260e5ca.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-ve8260e5ca.vsix create-cloudflare: npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13418999425/npm-package-create-cloudflare-7334 --no-auto-update @cloudflare/kv-asset-handler: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13418999425/npm-package-cloudflare-kv-asset-handler-7334 miniflare: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13418999425/npm-package-miniflare-7334 @cloudflare/pages-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13418999425/npm-package-cloudflare-pages-shared-7334 @cloudflare/unenv-preset: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13418999425/npm-package-cloudflare-unenv-preset-7334 @cloudflare/vite-plugin: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13418999425/npm-package-cloudflare-vite-plugin-7334 @cloudflare/vitest-pool-workers: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13418999425/npm-package-cloudflare-vitest-pool-workers-7334 @cloudflare/workers-editor-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13418999425/npm-package-cloudflare-workers-editor-shared-7334 @cloudflare/workers-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13418999425/npm-package-cloudflare-workers-shared-7334 @cloudflare/workflows-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13418999425/npm-package-cloudflare-workflows-shared-7334 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
86a4971
to
b35265a
Compare
* chore: remove alpha support from `wrangler d1 migrations apply` * chore: remove `wrangler d1 backups` * chore: fixup tests * chore: fixup tests * chore: fixup tests * chore: remove --batch-size
* Remove wrangler version * Remove generate & strip down init * Add changesets * Remove deprecated --format & config * Add changeset * remove commands * Fix tests * Remove .only() * Remove legacy assets * clarify legacy assets -> sites naming
esbuild 0.24.2 variable naming changes
* feat(wrangler): Drop worker prefix when creating KV namespaces * Remove crypto polyfill --------- Co-authored-by: Samuel Macleod <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: can we add a pre-requisites section to the wrangler readme that mentions this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the node app pages dev script in its package.json still uses the --node-compat
flag
Remaining test failures should be resolved by cloudflare/next-on-pages#940 |
@@ -0,0 +1,5 @@ | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--version is listed as a global command, but doesn't actually work on any command except for wrangler --version
as listed here. Can we get rid of it from the global flags group as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could, but if we did that I'm not sure where we'd document it?
(this also isn't a breaking change, so we could do this outside of the v4 scope)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a couple of places to update:
- error message in
getBindings
in wrangler/src/dev.ts mentions kv:namespace create - workers-chat-demo fixture has [build.upload] in its config
- legacy assets is mentioned in an error message in versions/secrets/index.ts in
parseModules()
|
||
Remove `wrangler d1 backups` | ||
|
||
BREAKING CHANGE: This change removes `wrangler d1 backups`, a set of alpha-only commands that would allow folks to interact with backups of their D1 alpha DBs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: in context, having BREAKING CHANGE on just a couple of the breaking changes could be a bit confusing, maybe we could remove this from these changesets?
.changeset/major-remove-d1-backups.md
.changeset/major-remove-d1-deprecated-batch-size.md
.changeset/major-remove-d1-migrations-alpha.md
"wrangler": major | ||
--- | ||
|
||
Remove legacy assets |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the --legacy-assets flag.
(and config key if there was one?)
Wrangler v4 is coming! We’re releasing this release candidate now as a way for you to check the upcoming version works with your projects. More detailed migration guides & documentation will be coming over the next few months as we prepare to roll this out, but a TLDR of the breaking changes to expect are:
esbuild
v0.24.2wrangler r2
andwrangler kv
are--local
by defaultTo try it out, install and use
wrangler@next
.Let us know what you think! We'd love to hear any feedback, either as comments on this PR or in the #wrangler channel on Discord.