Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make sure asset routing config is passed to vitest #7773

Merged
merged 3 commits into from
Jan 29, 2025

Conversation

emily-shen
Copy link
Contributor

@emily-shen emily-shen commented Jan 15, 2025

Fixes WC-3076


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: no e2e's for this
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: bugfix

@emily-shen emily-shen requested a review from a team as a code owner January 15, 2025 10:53
Copy link

changeset-bot bot commented Jan 15, 2025

🦋 Changeset detected

Latest commit: ae49399

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 15, 2025

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13029940705/npm-package-wrangler-7773

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7773/npm-package-wrangler-7773

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13029940705/npm-package-wrangler-7773 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13029940705/npm-package-cloudflare-workers-bindings-extension-7773 -O ./cloudflare-workers-bindings-extension.0.0.0-v3b83e6861.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v3b83e6861.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13029940705/npm-package-create-cloudflare-7773 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13029940705/npm-package-cloudflare-kv-asset-handler-7773

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13029940705/npm-package-miniflare-7773

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13029940705/npm-package-cloudflare-pages-shared-7773

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13029940705/npm-package-cloudflare-unenv-preset-7773

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13029940705/npm-package-cloudflare-vite-plugin-7773

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13029940705/npm-package-cloudflare-vitest-pool-workers-7773

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13029940705/npm-package-cloudflare-workers-editor-shared-7773

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13029940705/npm-package-cloudflare-workers-shared-7773

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13029940705/npm-package-cloudflare-workflows-shared-7773

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20250124.0
workerd 1.20250124.0 1.20250124.0
workerd --version 1.20250124.0 2025-01-24

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link
Member

@edmundhung edmundhung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a test to the vitest-pool-workers fixture?

@emily-shen emily-shen marked this pull request as draft January 15, 2025 12:59
@emily-shen emily-shen force-pushed the emily/vitest-assets-serve-directly branch from f5a0056 to f47e35c Compare January 29, 2025 11:00
@emily-shen emily-shen force-pushed the emily/vitest-assets-serve-directly branch from f47e35c to 6a11021 Compare January 29, 2025 11:03
@emily-shen emily-shen requested a review from edmundhung January 29, 2025 11:05
@emily-shen emily-shen marked this pull request as ready for review January 29, 2025 11:05
@emily-shen emily-shen changed the title fix: pass experimental_serve_directly to vitest fix: make sure asset routing config is passed to vitest Jan 29, 2025
@emily-shen emily-shen merged commit aa3ee63 into main Jan 29, 2025
27 of 28 checks passed
@emily-shen emily-shen deleted the emily/vitest-assets-serve-directly branch January 29, 2025 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants