Hotfix action #8192
Hotfix action #8192
Conversation
|
penalosa
added
the
skip-pr-description-validation
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13434663777/npm-package-wrangler-8192You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/8192/npm-package-wrangler-8192Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13434663777/npm-package-wrangler-8192 dev path/to/script.jsAdditional artifacts:cloudflare-workers-bindings-extension: wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13434663777/npm-package-cloudflare-workers-bindings-extension-8192 -O ./cloudflare-workers-bindings-extension.0.0.0-vd412313f4.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-vd412313f4.vsixcreate-cloudflare: npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13434663777/npm-package-create-cloudflare-8192 --no-auto-update@cloudflare/kv-asset-handler: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13434663777/npm-package-cloudflare-kv-asset-handler-8192miniflare: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13434663777/npm-package-miniflare-8192@cloudflare/pages-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13434663777/npm-package-cloudflare-pages-shared-8192@cloudflare/unenv-preset: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13434663777/npm-package-cloudflare-unenv-preset-8192@cloudflare/vite-plugin: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13434663777/npm-package-cloudflare-vite-plugin-8192@cloudflare/vitest-pool-workers: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13434663777/npm-package-cloudflare-vitest-pool-workers-8192@cloudflare/workers-editor-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13434663777/npm-package-cloudflare-workers-editor-shared-8192@cloudflare/workers-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13434663777/npm-package-cloudflare-workers-shared-8192@cloudflare/workflows-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13434663777/npm-package-cloudflare-workflows-shared-8192Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
| - In general, the best way to do this is to checkout the previous release of `workers-sdk`, apply the changes you need, and then increment the patch version of the packages that should be released as part of this hotfix. | ||
|
|
||
| - Get approvals for that PR, and make sure CI checks are passing | ||
| - Manually trigger a hotfix release from that PR using the "Release a hotfix" GitHub action. Optionally, you can first publish it to the `hotfix` tag on NPM in order to verify the release. |
There was a problem hiding this comment.
"Optionally, you can first publish it to the
hotfixtag on NPM in order to verify the release.
Comment"
is there a reason this shouldn't/can't be done? if no, i suggest we remove the "optionally" wording and explicitly direct to do this
There was a problem hiding this comment.
It's probably not really necessary, given we can test with the pre-release on the hotfix PR branch. We can likely remove this after we've merged and tested the hotfix workflow, but we need it for now so that we can run a test hotfix without overwriting npm latest
Co-authored-by: lrapoport-cf <[email protected]>
| if: ${{ inputs.confirm == true }} | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout Repo |
There was a problem hiding this comment.
would it make sense to check for user affiliation before checking out the repo?
Co-authored-by: Carmen Popoviciu <[email protected]>
Co-authored-by: Carmen Popoviciu <[email protected]>
| - Prepare a hotfix release PR: checkout the previous release of `workers-sdk`, apply the changes that should be in the hotfix, and then increment the patch version of the packages that should be released as part of the hotfix | ||
|
|
||
| - Get approvals for that PR, and make sure CI checks are passing | ||
| - Manually trigger a hotfix release from that PR using the "Release a hotfix" GitHub action. Optionally, you can first publish it to the `hotfix` tag on NPM in order to verify the release. |
There was a problem hiding this comment.
is it possible to link to where this action lives/or should be triggerred from?
|
|
||
| - Get approvals for that PR, and make sure CI checks are passing | ||
| - Manually trigger a hotfix release from that PR using the "Release a hotfix" GitHub action. Optionally, you can first publish it to the `hotfix` tag on NPM in order to verify the release. | ||
| - _[CRUCIAL]_ Once the hotfix release is out and verified, merge the fixes into main before the next regular release of `workers-sdk`. |
There was a problem hiding this comment.
I don't suppose we could automate this somehow 🤔 ... as in if a hotfix PR is released, a new PR to main with hotfix changes would be automatically created. Totally not in the scope of this PR...just thinking out loud
Fixes https://jira.cfdata.org/browse/DEVX-1231
This adds a manual action for triggering a hotfix release of Wrangler, Miniflare, or C3 outside of the regular changeset-based release process. It also includes instructions for how to prepare a hotfix release in the contributing guide.