Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify @cloudflare/workers-shared exports #8193

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

GregBrimble
Copy link
Contributor

Ages and ages ago, folks working on the Vite plugin asked me for better access to the asset-worker and router-worker, but looks like they've already been pulling from workers-shared quite reasonably. This keeps that, and removes the old copy-config stuff we were once using in Miniflare (Miniflare has been spinning up the Worker with its own config for a while now).


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: existing coverage
  • Wrangler E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: no coverage
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: internal change

@GregBrimble GregBrimble requested review from a team as code owners February 19, 2025 14:16
Copy link

changeset-bot bot commented Feb 19, 2025

🦋 Changeset detected

Latest commit: 6417bfc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudflare/workers-shared Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Feb 19, 2025

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13416238437/npm-package-wrangler-8193

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/8193/npm-package-wrangler-8193

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13416238437/npm-package-wrangler-8193 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13416238437/npm-package-cloudflare-workers-bindings-extension-8193 -O ./cloudflare-workers-bindings-extension.0.0.0-vfd81c4e97.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-vfd81c4e97.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13416238437/npm-package-create-cloudflare-8193 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13416238437/npm-package-cloudflare-kv-asset-handler-8193

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13416238437/npm-package-miniflare-8193

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13416238437/npm-package-cloudflare-pages-shared-8193

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13416238437/npm-package-cloudflare-unenv-preset-8193

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13416238437/npm-package-cloudflare-vite-plugin-8193

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13416238437/npm-package-cloudflare-vitest-pool-workers-8193

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13416238437/npm-package-cloudflare-workers-editor-shared-8193

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13416238437/npm-package-cloudflare-workers-shared-8193

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13416238437/npm-package-cloudflare-workflows-shared-8193

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20250214.0
workerd 1.20250214.0 1.20250214.0
workerd --version 1.20250214.0 2025-02-14

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@GregBrimble GregBrimble force-pushed the simplify-workers-shared-exports branch 4 times, most recently from deb587b to f500431 Compare February 19, 2025 14:48
@GregBrimble GregBrimble force-pushed the simplify-workers-shared-exports branch from f500431 to 6417bfc Compare February 19, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Untriaged
Development

Successfully merging this pull request may close these issues.

1 participant