-
Notifications
You must be signed in to change notification settings - Fork 786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always use labels for E2E #8194
Conversation
|
e2e: | ||
- all: | ||
- any: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any meaning for switcing from all
to any
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's because we're adding multiple conditions (previously we only had one per lable, so it didn't matter)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh! It's like an "AND" vs "OR" constraint?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13416920924/npm-package-wrangler-8194 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/8194/npm-package-wrangler-8194 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13416920924/npm-package-wrangler-8194 dev path/to/script.js Additional artifacts:cloudflare-workers-bindings-extension: wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13416920924/npm-package-cloudflare-workers-bindings-extension-8194 -O ./cloudflare-workers-bindings-extension.0.0.0-v494cdd217.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v494cdd217.vsix create-cloudflare: npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13416920924/npm-package-create-cloudflare-8194 --no-auto-update @cloudflare/kv-asset-handler: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13416920924/npm-package-cloudflare-kv-asset-handler-8194 miniflare: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13416920924/npm-package-miniflare-8194 @cloudflare/pages-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13416920924/npm-package-cloudflare-pages-shared-8194 @cloudflare/unenv-preset: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13416920924/npm-package-cloudflare-unenv-preset-8194 @cloudflare/vite-plugin: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13416920924/npm-package-cloudflare-vite-plugin-8194 @cloudflare/vitest-pool-workers: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13416920924/npm-package-cloudflare-vitest-pool-workers-8194 @cloudflare/workers-editor-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13416920924/npm-package-cloudflare-workers-editor-shared-8194 @cloudflare/workers-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13416920924/npm-package-cloudflare-workers-shared-8194 @cloudflare/workflows-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13416920924/npm-package-cloudflare-workflows-shared-8194 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
Simplifies the E2E setup by only running C3 E2E and Wrangler E2E when the relevant label is applied, and then automatically applying that label to Version Packages. Previously, in some cases E2E tests were running twice on Version Packages (because of the automatic label, and then the override to always run on Version Packages)
Additionally, remove the
skip-pr-description
label from Version Packages, since PR description validation is already skipped on that branch.