Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always use labels for E2E #8194

Merged
merged 1 commit into from
Feb 19, 2025
Merged

Always use labels for E2E #8194

merged 1 commit into from
Feb 19, 2025

Conversation

penalosa
Copy link
Contributor

Simplifies the E2E setup by only running C3 E2E and Wrangler E2E when the relevant label is applied, and then automatically applying that label to Version Packages. Previously, in some cases E2E tests were running twice on Version Packages (because of the automatic label, and then the override to always run on Version Packages)

Additionally, remove the skip-pr-description label from Version Packages, since PR description validation is already skipped on that branch.

@penalosa penalosa added the skip-pr-description-validation Skip validation of the required PR description format label Feb 19, 2025
@penalosa penalosa requested a review from a team as a code owner February 19, 2025 16:00
Copy link

changeset-bot bot commented Feb 19, 2025

⚠️ No Changeset found

Latest commit: 2bd2c3f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

e2e:
- all:
- any:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any meaning for switcing from all to any here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's because we're adding multiple conditions (previously we only had one per lable, so it didn't matter)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh! It's like an "AND" vs "OR" constraint?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13416920924/npm-package-wrangler-8194

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/8194/npm-package-wrangler-8194

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13416920924/npm-package-wrangler-8194 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13416920924/npm-package-cloudflare-workers-bindings-extension-8194 -O ./cloudflare-workers-bindings-extension.0.0.0-v494cdd217.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v494cdd217.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13416920924/npm-package-create-cloudflare-8194 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13416920924/npm-package-cloudflare-kv-asset-handler-8194

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13416920924/npm-package-miniflare-8194

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13416920924/npm-package-cloudflare-pages-shared-8194

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13416920924/npm-package-cloudflare-unenv-preset-8194

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13416920924/npm-package-cloudflare-vite-plugin-8194

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13416920924/npm-package-cloudflare-vitest-pool-workers-8194

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13416920924/npm-package-cloudflare-workers-editor-shared-8194

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13416920924/npm-package-cloudflare-workers-shared-8194

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13416920924/npm-package-cloudflare-workflows-shared-8194

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20250214.0
workerd 1.20250214.0 1.20250214.0
workerd --version 1.20250214.0 2025-02-14

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@penalosa penalosa merged commit 4f910cf into main Feb 19, 2025
23 of 24 checks passed
@penalosa penalosa deleted the penalosa/simplify-e2e branch February 19, 2025 17:40
emily-shen pushed a commit that referenced this pull request Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-pr-description-validation Skip validation of the required PR description format
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants