Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Miniflare 2 #8200

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Remove Miniflare 2 #8200

wants to merge 5 commits into from

Conversation

penalosa
Copy link
Contributor

Remove the last vestiges of Miniflare v2 from workers-sdk (by way of pages-shared). In particular, this PR:

  • Directly depends on html-rewriter-wasm rather than the Miniflare wrapper
  • Migrates the @cloudflare/pages-shared package to run tests via @cloudflare/vitest-pool-workers

cc @mrbbot —the end of an era!


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: covered by existing tests
  • Wrangler E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: internal change

@penalosa penalosa requested review from a team as code owners February 19, 2025 20:03
Copy link

changeset-bot bot commented Feb 19, 2025

🦋 Changeset detected

Latest commit: bd859c7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudflare/pages-shared Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@penalosa penalosa added the e2e Run wrangler e2e tests on a PR label Feb 19, 2025
Copy link
Contributor

github-actions bot commented Feb 19, 2025

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13434077518/npm-package-wrangler-8200

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/8200/npm-package-wrangler-8200

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13434077518/npm-package-wrangler-8200 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13434077518/npm-package-cloudflare-workers-bindings-extension-8200 -O ./cloudflare-workers-bindings-extension.0.0.0-v5c9082764.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v5c9082764.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13434077518/npm-package-create-cloudflare-8200 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13434077518/npm-package-cloudflare-kv-asset-handler-8200

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13434077518/npm-package-miniflare-8200

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13434077518/npm-package-cloudflare-pages-shared-8200

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13434077518/npm-package-cloudflare-unenv-preset-8200

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13434077518/npm-package-cloudflare-vite-plugin-8200

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13434077518/npm-package-cloudflare-vitest-pool-workers-8200

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13434077518/npm-package-cloudflare-workers-editor-shared-8200

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13434077518/npm-package-cloudflare-workers-shared-8200

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13434077518/npm-package-cloudflare-workflows-shared-8200

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20250214.0
workerd 1.20250214.0 1.20250214.0
workerd --version 1.20250214.0 2025-02-14

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@DaniFoldi
Copy link
Contributor

DaniFoldi commented Feb 19, 2025

@penalosa does this mean that the miniflare repo will also be archived?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run wrangler e2e tests on a PR
Projects
Status: Untriaged
Development

Successfully merging this pull request may close these issues.

3 participants