#105 revert change cas enabled and optional to string, where unnecessary

cloudogu · Feb 3, 2025 · 44b8b58 · 44b8b58
1 parent 69a0022
commit 44b8b58
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/terraform/ces-module/variables.tf b/terraform/ces-module/variables.tf
@@ -191,11 +191,11 @@ variable "cas_oidc_config" {
     initial_admin_usernames = string
   })
   default = {
-    enabled                 = "false"
+    enabled                 = false
     discovery_uri           = ""
     client_id               = ""
     display_name            = "CAS oidc provider"
-    optional                = "false"
+    optional                = false
     scopes                  = "openid email profile groups"
     attribute_mapping       = "email:mail,family_name:surname,given_name:givenName,preferred_username:username,name:displayName,groups:externalGroups"
     principal_attribute     = "preferred_username"

diff --git a/terraform/examples/ces_keycloak_gke/main.tf b/terraform/examples/ces_keycloak_gke/main.tf
@@ -143,7 +143,7 @@ module "ces" {
   helm_registry_password = var.helm_registry_password
 
   cas_oidc_config = {
-    enabled                 = "true"
+    enabled                 = true
     discovery_uri           = "${var.keycloak_url}/realms/${var.keycloak_realm_id}/.well-known/openid-configuration"
     client_id               = local.external_cas_openid_client_id
     display_name            = "CAS oidc provider"

diff --git a/terraform/examples/ces_keycloak_gke/variables_ces.tf b/terraform/examples/ces_keycloak_gke/variables_ces.tf
@@ -82,8 +82,8 @@ variable "cas_oidc_optional" {
   via the OIDC provider optional. This is done by displaying an additional button for the OIDC provider on the login
   page of the CAS, which can be used to authenticate with the OIDC provider.
   EOT
-  type = string
-  default = "false"
+  type = bool
+  default = false
 }
 
 variable "cas_oidc_allowed_groups" {