-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/105 add ability to configure cas OIDC authenticator with terraform #106
Feature/105 add ability to configure cas OIDC authenticator with terraform #106
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please reduce the complexity of the example. The intention of this is, that customers can copy the code and can modify it for there needs. Only the modules need to be configurable and ready for production.
terraform/examples/ces_keycloak_gke/ces_cluster/variables_gke.tf
Outdated
Show resolved
Hide resolved
terraform/keycloak-client-module/ces-service-account-client.json
Outdated
Show resolved
Hide resolved
terraform/examples/ces_keycloak_gke/ces_cluster/variables_ces.tf
Outdated
Show resolved
Hide resolved
…gure-cas-oidc-authonticator-with-terraform' into feature/105-add-ability-to-configure-cas-oidc-authonticator-with-terraform
a000548
to
2a25b52
Compare
trying to fix following error: failed to write registry config data to registry: failed to write entries in registry config: failed to write oidc in registry config: unexpected type bool for oidc/enabled
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Resolves #105