Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hi] Localize virtualization.md to Hindi #1674

Merged
merged 3 commits into from
Nov 14, 2023

Conversation

SaxenaAnushka102
Copy link
Contributor

@SaxenaAnushka102 SaxenaAnushka102 commented Jan 27, 2023

Signed-off-by: ANUSHKA SAXENA [email protected]

Describe your changes

Created a file virualization.md to localize the page: https://glossary.cncf.io/virtualization/ into Hindi

Related issue number

Resolves #1597

Checklist before opening this PR

  • This PR does not contain plagiarism
  • I have signed off on all commits

Created a file called virualization.md to localize the page: https://glossary.cncf.io/virtualization/ into Hindi
Resolves cncf#1597


Signed-off-by: ANUSHKA SAXENA <[email protected]>
@netlify
Copy link

netlify bot commented Jan 27, 2023

Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit b2017a5
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/655028e9a0b46c00088900e1
😎 Deploy Preview https://deploy-preview-1674--cncfglossary.netlify.app/hi/virtualization
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jihoon-seo jihoon-seo added the lang/hi for Hindi label Jan 29, 2023
Signed-off-by: ANUSHKA SAXENA <[email protected]>
Copy link
Collaborator

@aj11anuj aj11anuj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions from my side

content/hi/virtualization.md Outdated Show resolved Hide resolved
content/hi/virtualization.md Outdated Show resolved Hide resolved
content/hi/virtualization.md Outdated Show resolved Hide resolved
content/hi/virtualization.md Outdated Show resolved Hide resolved
Signed-off-by: Anuj Tiwari <[email protected]>
Copy link
Collaborator

@aj11anuj aj11anuj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm 👍

@aj11anuj aj11anuj added the Awaiting/2nd-approval This PR needs another approval review label Nov 12, 2023
Copy link
Contributor

@justankiit justankiit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@justankiit justankiit removed the Awaiting/2nd-approval This PR needs another approval review label Nov 14, 2023
@SaxenaAnushka102 SaxenaAnushka102 changed the base branch from main to dev-hi November 14, 2023 17:12
@bishal7679
Copy link
Collaborator

It seems this PR is ready to merge!
Just let me go through a final review once!

@justankiit justankiit merged commit f299bc1 into cncf:dev-hi Nov 14, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/hi for Hindi
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Virtualization For hindi
5 participants