Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI & docs] Set up link checker + GH action + fix en links #3188

Merged
merged 3 commits into from
Jun 10, 2024
Merged

[CI & docs] Set up link checker + GH action + fix en links #3188

merged 3 commits into from
Jun 10, 2024

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Jun 8, 2024 •
edited
Loading

  • Contributes to Enable link checking (paths) across languages #3190
  • Adds support for link checking using htmltest
  • Adds a GitHub workflow that checks link for every submitted PR
  • Configures htmltest to ignore all locales except for en for starters. Locales can be incrementally added
  • Fixes broken links in en pages
  • Adds NPM scripts to handle common tasks
    • Note that running npm install will now also fetch Docsy
  • Copyedits the README

/cc @cjyabraham @nate-double-u

@github-actions github-actions bot added the lang/en for English label Jun 8, 2024
@netlify Netlify
Copy link

netlify bot commented Jun 8, 2024 •
edited
Loading

✅ Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit b9cdd31
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/6664f0f6fc99860008cfd482
😎 Deploy Preview https://deploy-preview-3188--cncfglossary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@chalin chalin changed the title Chalin im link checking and more 2024 06 08 [CI & docs] Set up link checker + GH action + fix links Jun 8, 2024
@chalin chalin mentioned this pull request Jun 9, 2024
Open
15 tasks
@chalin chalin changed the title [CI & docs] Set up link checker + GH action + fix links [CI & docs] Set up link checker + GH action + fix en links Jun 9, 2024
nate-double-u
nate-double-u approved these changes Jun 10, 2024
View reviewed changes
Copy link
Member

@nate-double-u nate-double-u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @chalin, a useful tool!

jihoon-seo
jihoon-seo approved these changes Jun 10, 2024
View reviewed changes
Copy link
Collaborator

@jihoon-seo jihoon-seo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@nate-double-u nate-double-u merged commit 541307c into cncf:main Jun 10, 2024
7 checks passed
@chalin chalin deleted the chalin-im-link-checking-and-more-2024-06-08 branch June 13, 2024 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nate-double-u nate-double-u nate-double-u approved these changes

@jihoon-seo jihoon-seo jihoon-seo approved these changes

@caniszczyk caniszczyk Awaiting requested review from caniszczyk caniszczyk is a code owner

@seokho-son seokho-son Awaiting requested review from seokho-son seokho-son is a code owner

@iamNoah1 iamNoah1 Awaiting requested review from iamNoah1 iamNoah1 is a code owner

@castrojo castrojo Awaiting requested review from castrojo castrojo is a code owner

Assignees
No one assigned
Labels
lang/en for English
Projects
CNCF glossary definition review board
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chalin @nate-double-u @jihoon-seo