CH32V30x: Fix PLL_MULTIPLICATION definition for ch32v303 #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiling for a ch32v303 (which is part of the ch32v30x_D8), the build was failing because
FUNCONF_PLL_MULTIPLIERis set to 18 (for all ch32v30x), but the code test for 18 only for the ch32v20x. This cause the build to errors with the message "Invalid PLL multiplier".I also modified the condition before the declaration of
RCC_PLLMULL18, to include all ch32v30x_D8.I didn't really test directly the modifications, as I used this with Zephyr, which use the macros
RCC_PLLMul_x(they have the same value as the macrosRCC_PLLMULLx, I don't really understand the difference).