Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(blob): ignore Content-Length mismatch if Content-Encoding set #78

Merged
merged 1 commit into from
Jan 18, 2025
Merged

fix(blob): ignore Content-Length mismatch if Content-Encoding set #78

merged 1 commit into from
Jan 18, 2025

Conversation

incognitojam
Copy link
Member

@incognitojam incognitojam commented Jan 18, 2025 •
edited
Loading

We were comparing the Content-Length header to the length of the decompressed body, which fetch/the browser silently does for us.

@incognitojam incognitojam merged commit a32b8fd into master Jan 18, 2025
3 checks passed
@incognitojam incognitojam deleted the content-encoding-skip-length-check branch January 18, 2025 12:58
incognitojam added a commit that referenced this pull request Jan 18, 2025
@incognitojam
Revert "fix(blob): ignore Content-Length mismatch if Content-Encoding…
d7e2cc5 
… set (#78)"

This reverts commit a32b8fd.
@incognitojam incognitojam mentioned this pull request Jan 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@incognitojam