Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add adb toggle to developerPanel #34459

Merged
merged 12 commits into from
Jan 25, 2025

Conversation

BBBmau
Copy link
Contributor

@BBBmau BBBmau commented Jan 24, 2025

finish task for #34041

@github-actions github-actions bot added the ui label Jan 24, 2025
Copy link
Contributor

github-actions bot commented Jan 24, 2025

UI Preview

settings_developer : $${\color{red}\text{DIFFERENT}}$$
master proposed
diff composite diff
keyboard : $${\color{red}\text{DIFFERENT}}$$
master proposed
diff composite diff
keyboard_uppercase : $${\color{red}\text{DIFFERENT}}$$
master proposed
diff composite diff
All Screenshots

@BBBmau BBBmau marked this pull request as draft January 24, 2025 02:49
@BBBmau
Copy link
Contributor Author

BBBmau commented Jan 24, 2025

should be good now, just need to do some manual validation

@BBBmau BBBmau marked this pull request as ready for review January 24, 2025 07:02
@BBBmau BBBmau force-pushed the adb-toggle-developer branch 2 times, most recently from 8e02996 to a696556 Compare January 24, 2025 19:12
@BBBmau BBBmau force-pushed the adb-toggle-developer branch from a696556 to 11ebfab Compare January 24, 2025 19:18
@BBBmau
Copy link
Contributor Author

BBBmau commented Jan 24, 2025

Finished validating, we can merge this now:

Adb toggle activated:
PXL_20250124_223311714.MP.jpg

Adb toggle inactive:PXL_20250124_223324102.MP.jpg

What's nice is if you're correctly in adb shell before the openpilot startup it will stay active.

@BBBmau BBBmau force-pushed the adb-toggle-developer branch from ca369b5 to 3dbb257 Compare January 25, 2025 05:16
@adeebshihadeh adeebshihadeh merged commit c57f535 into commaai:master Jan 25, 2025
17 checks passed
@sshane
Copy link
Contributor

sshane commented Jan 26, 2025

The ui differ is broken from the different coordinates

@adeebshihadeh
Copy link
Contributor

adeebshihadeh commented Jan 26, 2025

@maxime-desroches why didn't CI fail?

Oh, I see the diff is just large and not showing the right stuff. @BBBmau can you fix?

@BBBmau
Copy link
Contributor Author

BBBmau commented Jan 26, 2025

@maxime-desroches why didn't CI fail?

Oh, I see the diff is just large and not showing the right stuff. @BBBmau can you fix?

i don't see any issues with the ui differ from looking at the UI preview comment from my latest PR: #34481 (comment)

The tests are just failing due to missing translations but that PR would fix it by checking any changes with selfdrive/ui/**a and running update_translations.py to commit and push any changes found there.

Edit: ohhh i see the developerPanel is marked as keyboard.png. Yeah I'll fix that asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants