Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add osgi headers via maven-bundle-plugin #359

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

zspitzer
Copy link

@zspitzer zspitzer commented Jan 19, 2025

following up on #128

this PR adds the maven-bundle-plugin and config

I am doing this, as we use Commonmark in Lucee, for the initial version, we wrapped the jar ourselves with OSGI metadata, but now I'd like to add some extensions and I'd rather just use commonmark jars

lucee/Lucee#2473

I have tested this locally and the OSGI Export-Package / Import-Package headers look good

But there are some warnings be thrown for each extension

[INFO] --- bundle:6.0.0:bundle (bundle) @ commonmark-ext-autolink ---
[WARNING] Bundle org.commonmark:commonmark-ext-autolink:jar:0.24.1-SNAPSHOT : Split package, multiple jars provide the same package:
Use Import/Export Package directive -split-package:=(merge-first|merge-last|error|first) to get rid of this warning
Package found in   [Jar:., Jar:commonmark, Jar:autolink]
Class path         [Jar:., Jar:commonmark, Jar:autolink]
[INFO] Building bundle: D:\work\java\commonmark-java\commonmark-ext-autolink\target\commonmark-ext-autolink-0.24.1-SNAPSHOT.jar
[INFO] Writing manifest: D:\work\java\commonmark-java\commonmark-ext-autolink\target\classes\META-INF\MANIFEST.MF

In addition, the autolink dependancy also needs OSGI metadata

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant