Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix conda_package_build "build" column type #1011

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Fix conda_package_build "build" column type #1011

merged 1 commit into from
Dec 9, 2024

Conversation

soapy1
Copy link
Contributor

@soapy1 soapy1 commented Dec 6, 2024 •
edited
Loading

Description

This should be a string instead of an int, for example "py310h06a4308_0". This was probably updated to the wrong type by accident as part of #970

Pull request checklist

  • Did you test this change locally?
  • Did you update the documentation (if required)?
  • Did you add/update relevant tests for this change (if required)?

@soapy1
Fix conda_package_build "build" column type
cd2f925 
This should be a string, for example "py310h06a4308_0"
@soapy1 soapy1 requested a review from peytondmurray December 6, 2024 00:53
@netlify Netlify
Copy link

netlify bot commented Dec 6, 2024 •
edited
Loading

✅ Deploy Preview for conda-store canceled.

Name Link
🔨 Latest commit cd2f925
🔍 Latest deploy log https://app.netlify.com/sites/conda-store/deploys/67524b0c1d294300085d1ad4

@soapy1 soapy1 marked this pull request as draft December 6, 2024 03:32
@soapy1 soapy1 marked this pull request as ready for review December 6, 2024 15:52
peytondmurray
peytondmurray approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@peytondmurray peytondmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this - did the problematic commit get released?

@soapy1
Copy link
Contributor Author

soapy1 commented Dec 9, 2024

Thanks for this - did the problematic commit get released?

yep, should have. Though it doesn't seem to have broken anything.

@soapy1 soapy1 merged commit 7642a27 into conda-incubator:main Dec 9, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peytondmurray peytondmurray peytondmurray approved these changes

Assignees
No one assigned
Labels
needs: review 👀
Projects
conda-store 🐍
Status: Done 💪🏾
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@soapy1 @peytondmurray