Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build docker images for arm (aarch64) #822

Merged
merged 3 commits into from
Jul 23, 2024

Conversation

aktech
Copy link
Contributor

@aktech aktech commented May 8, 2024

Fixes #821

Description

This pull request:

  • Add another matrix item in the CI to build docker images for arm.

Pull request checklist

  • Did you test this change locally?
  • Did you update the documentation (if required)?
  • Did you add/update relevant tests for this change (if required)?

Additional information

How to test

Copy link

netlify bot commented May 8, 2024

Deploy Preview for conda-store canceled.

Name Link
🔨 Latest commit 70f2618
🔍 Latest deploy log https://app.netlify.com/sites/conda-store/deploys/66996cfe6bbbd60008082249

@trallard
Copy link
Collaborator

trallard commented Jul 8, 2024

@aktech this has been in WIP for a bit. Are you planning to continue to work on this PR?

@aktech
Copy link
Contributor Author

aktech commented Jul 8, 2024

Yes. The windows test failure is unrelated: https://github.com/conda-incubator/conda-store/actions/runs/9006701345/job/25302259825?pr=822

and the docker image build got stalled, needs to be re-triggered.

The docker image built fine on my fork: https://github.com/aktech/conda-store/actions/runs/9003040226/job/24732748267

@aktech
Copy link
Contributor Author

aktech commented Jul 8, 2024

also, would need workflow trigger approval (potentially multiple times) to make it green

@peytondmurray
Copy link
Contributor

Updated branch to trigger workflows, let's see if we can get this merged.

@aktech aktech marked this pull request as ready for review July 23, 2024 15:26
@aktech
Copy link
Contributor Author

aktech commented Jul 23, 2024

This is ready for review, CI is green now.

Copy link

@marcelovilla marcelovilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aktech 🚀 !

@peytondmurray peytondmurray added the needs: discussion 💬 This item needs team-level discussion before scoping label Jul 23, 2024
@marcelovilla
Copy link

@peytondmurray is there any reason not to approve this? I see you added the needs: discussion label.

@peytondmurray
Copy link
Contributor

Nope, I'll merge it now - that label as added so I could easily filter for it during today's meeting.

@peytondmurray peytondmurray self-requested a review July 23, 2024 20:40
Copy link
Contributor

@peytondmurray peytondmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Thanks for this!

@peytondmurray peytondmurray merged commit 0ade4b1 into conda-incubator:main Jul 23, 2024
29 checks passed
@aktech aktech deleted the arm-docker-image branch July 23, 2024 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: discussion 💬 This item needs team-level discussion before scoping status: stale 🥖
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

[ENH] - Build docker images for arm (aarch64)
4 participants