-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build docker images for arm (aarch64) #822
Conversation
✅ Deploy Preview for conda-store canceled.
|
@aktech this has been in WIP for a bit. Are you planning to continue to work on this PR? |
Yes. The windows test failure is unrelated: https://github.com/conda-incubator/conda-store/actions/runs/9006701345/job/25302259825?pr=822 and the docker image build got stalled, needs to be re-triggered. The docker image built fine on my fork: https://github.com/aktech/conda-store/actions/runs/9003040226/job/24732748267 |
also, would need workflow trigger approval (potentially multiple times) to make it green |
Updated branch to trigger workflows, let's see if we can get this merged. |
This is ready for review, CI is green now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @aktech 🚀 !
@peytondmurray is there any reason not to approve this? I see you added the |
Nope, I'll merge it now - that label as added so I could easily filter for it during today's meeting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 Thanks for this!
Fixes #821
Description
This pull request:
Pull request checklist
Additional information
How to test