-
Notifications
You must be signed in to change notification settings - Fork 633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CANARY] Disable test retries #3189
Conversation
Of course, please do not restart any of these manually. |
3eae9de
to
ef46b8f
Compare
2d0d19f
to
320016c
Compare
9ee9715
to
d6747eb
Compare
Green again, but #3225 is still a clear issue before we can consider merging this. |
10d0659
to
01713d3
Compare
064f038
to
479e2f4
Compare
08/09/2024:
Run: https://github.com/containerd/nerdctl/actions/runs/10323534574/job/28581121980 The logs one is perplexing, but far from being the only log problem in CI. We should really have a look at logs overall. The IPFS one is also happening often - |
479e2f4
to
097f54a
Compare
Signed-off-by: apostasie <[email protected]>
097f54a
to
eba00db
Compare
Closing in favor of #3305 |
IMHO we cannot keep on hiding problems by "retrying tests" until it works.
This is a doomed approach.
I perfectly understand how painful it is to go and debug these flakyness / concurrency issues, and that it is much easier to ignore the problem - but we have to solve these - they are definitely indicative of deep quality issues and the only way to do so is to make it as obvious as possible instead of hiding it under the retry-carpet.
This is a canary PR that will very likely keep failing for some time - until we fix ALL these issues.
I will rebase it against main daily, and eventually we should get it green and stable.
Finally note that this canary is usually AHEAD of main - using commits from pending PRs fixing flakyness