fix: enable --env-file flag behavior in nerdctl compose #3703
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While debugging this issue on finch - Unable to use the "--env-file" option on "finch compose up" command #890
I noticed that nerdctl also fails to set the env variables within the container when using the "--env-file" option.
This behavior is also seen on
nerdctl compose run
command as well.Digging around the up_service.go file I noticed that we're not passing the --env-file flag to the run command here
Adding
--env-file
to the Run argument fixes the issue for bothcompose up
andcompose run
commands.Testing done:
Verified that the env variables are available within the container.