Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CORL-3216]: replace giphy/react-components with shared GifGrid for Giphy/Tenor #4731

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

kabeaty
Copy link
Contributor

@kabeaty kabeaty commented Feb 6, 2025

What does this PR do?

These changes:

  • remove the dependencies @giphy/react-components, @emotion/cache, and @emotion/core
  • remove EmotionShadowRoot since that was there to support the @giphy/react-components
  • refactor so that Giphy now uses the same grid as Tenor gifs to display its gif previews
  • additional refactors to reuse same component for Giphy/Tenor search input since they were already basically the same and component was there
  • update/enlarge gif sizing for both Tenor and Giphy grids

These changes will impact:

  • commenters
  • moderators
  • admins
  • developers

What changes to the GraphQL/Database Schema does this PR introduce?

none

Does this PR introduce any new environment variables or feature flags?

no

If any indexes were added, were they added to INDEXES.md?

n/a

How do I test this PR?

pnpm install to get latest dependency updates in client

You can test this PR by testing both Giphy and Tenor gif functionality. They can be toggled between in Configure --> General --> Embedded Media.

Their grids should function the same way now. When you search, you should see the gifs and have ability to load more and select your gif of choice to add to a comment. Try different searches and combinations of new searches and loading more.

Were any tests migrated to React Testing Library?

no

How do we deploy this PR?

Copy link

netlify bot commented Feb 6, 2025

Deploy Preview for gallant-galileo-14878c canceled.

Name Link
🔨 Latest commit 642bf19
🔍 Latest deploy log https://app.netlify.com/sites/gallant-galileo-14878c/deploys/67a4e9e1b797f1000829b448

@kabeaty kabeaty requested a review from nick-funk February 6, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant