Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Go to 1.21 following upstream Coraza #285

Merged
merged 3 commits into from
Jul 21, 2024
Merged

Bump Go to 1.21 following upstream Coraza #285

merged 3 commits into from
Jul 21, 2024

Conversation

M4tteoP
Copy link
Member

@M4tteoP M4tteoP commented Jul 20, 2024

@M4tteoP M4tteoP requested a review from jcchavezs as a code owner July 20, 2024 11:38
fzipi
fzipi approved these changes Jul 20, 2024
View reviewed changes
Copy link
Member

@fzipi fzipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent. Maybe we can use renovatebot for this?

@jcchavezs
Copy link
Member

@fzipi it could be a good idea but I would say upgrading go here is a very sensitive task as you need to align tinygo version and compilation and etc so I would not trust an automated PR.

@jcchavezs jcchavezs merged commit d1d6f28 into corazawaf:main Jul 21, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzipi fzipi fzipi approved these changes

@jcchavezs jcchavezs Awaiting requested review from jcchavezs jcchavezs is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@M4tteoP @jcchavezs @fzipi