Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(crosshairs): configurable viewportIndicators #1268

Merged
merged 3 commits into from
May 23, 2024

Conversation

IbrahimCSAE
Copy link
Collaborator

#Context

Fixes the viewport indicator circle so it takes the device pixel ratio in account

@IbrahimCSAE IbrahimCSAE requested a review from sedghi May 22, 2024 13:29
Copy link

netlify bot commented May 22, 2024

Deploy Preview for cornerstone-3d-docs ready!

Name Link
🔨 Latest commit fccd144
🔍 Latest deploy log https://app.netlify.com/sites/cornerstone-3d-docs/deploys/664f91d939e96900088a2462
😎 Deploy Preview https://deploy-preview-1268--cornerstone-3d-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sedghi sedghi changed the title fix(crosshairs): viewport indicator pixel ratio fix(crosshairs): configurable viewportIndicators May 23, 2024
@sedghi sedghi merged commit 268f1b1 into main May 23, 2024
10 checks passed
@sedghi sedghi deleted the fix/crosshairs-pixel-ratio branch January 22, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants