Wait until beforeSend header is returned before sending xhr request #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for cornerstone-wado-image-loader failed.
|
|
with the code of your PR commit, the beforeSend is still sync |
|
@wayfarer3130 Can you please look at this? |
wayfarer3130
reviewed
Dec 1, 2022
|
|
||
| let beforeSendHeaders = {}; | ||
| try{ | ||
| beforeSendHeaders = options.beforeSend( |
There was a problem hiding this comment.
This is still a synchronous call. This is also not the current version - there is an options.open method that runs before on line 23. Since this is already a promise, it should be easy to change this into an async function on line 4, then return the result directly down below.
There was a problem hiding this comment.
Yes it seems to be outdated base, @erasromani can you please rebase?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, beforeSend method passes is asynchronous or returns a promise. For example, when the xhr request requires addition of an access token in the header and the retreival of the access token is done asynchronously, the beforeSend methos is therefore asynchronous. In this case, the current implementation does not wait for the header to be returned before sending the xhr request.