coordinator bypass recovery SAI-4705

[noblepaul]

https://fullstory.atlassian.net/jira/software/c/projects/SAI/boards/78?selectedIssue=SAI-4705

[hiteshk25]

Adding, in our previous queryaggregator implementation we have avoided all these checks by creating proxy core (by overriding few functions in SolrCore class). That avoided exposing collection to zookeeper. As exposing collection further creates issue (if app is ZK, or some solr cluster api which returns that collection).

[noblepaul]

These checks are not required. These are just optimisations.

[hiteshk25]

@noblepaul i'm merging this into fs/branch_9_3. Can you open another pr to merge same in fs/branch_9x

[hiteshk25]

LGTM

[hiteshk25]

Coordinator test is failing

135 actionable tasks: 133 executed, 2 up-to-date
  - org.apache.solr.search.TestCoordinatorRole.testMultiCollectionMultiNode (:solr:core)
    Test output: /home/runner/work/fullstory-solr/fullstory-solr/solr/core/build/test-results/test/outputs/OUTPUT-org.apache.solr.search.TestCoordinatorRole.txt
    Reproduce with: gradlew :solr:core:test --tests "org.apache.solr.search.TestCoordinatorRole.testMultiCollectionMultiNode" -Ptests.jvms=1 "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:+UseParallelGC -XX:ActiveProcessorCount=1 -XX:ReservedCodeCacheSize=120m" -Ptests.seed=CB55CCE4A0420D83 -Ptests.file.encoding=US-ASCII

[hiteshk25]

  2> 3510517 ERROR (recoveryExecutor-51805-thread-1-processing-127.0.0.1:46337_solr .sys.COORDINATOR-COLL-conf_shard1_replica_n3 .sys.COORDINATOR-COLL-conf shard1 core_node4) [n:127.0.0.1:46337_solr c:.sys.COORDINATOR-COLL-conf s:shard1 r:core_node4 x:.sys.COORDINATOR-COLL-conf_shard1_replica_n3] o.a.s.c.RecoveryStrategy 
  2>           => java.lang.NullPointerException
  2> 	at org.apache.solr.cloud.ZkController.publish(ZkController.java:1719)
  2> java.lang.NullPointerException: null
  2> 	at org.apache.solr.cloud.ZkController.publish(ZkController.java:1719) ~[main/:9.3.0-SNAPSHOT abc0655cce152ac6a4fda1b8632bb90667209294 [snapshot build, details omitted]]
  2> 	at org.apache.solr.cloud.ZkController.publish(ZkController.java:1708) ~[main/:9.3.0-SNAPSHOT abc0655cce152ac6a4fda1b8632bb90667209294 [snapshot build, details omitted]]
  2> 	at org.apache.solr.cloud.RecoveryStrategy.doRecovery(RecoveryStrategy.java:336) ~[main/:9.3.0-SNAPSHOT abc0655cce152ac6a4fda1b8632bb90667209294 [snapshot build, details omitted]]
  2> 	at org.apache.solr.cloud.RecoveryStrategy.run(RecoveryStrategy.java:312) [main/:9.3.0-SNAPSHOT abc0655cce152ac6a4fda1b8632bb90667209294 [snapshot build, details omitted]]
  2> 	at com.codahale.metrics.InstrumentedExecutorService$InstrumentedRunnable.run(InstrumentedExecutorService.java:212) [metrics-core-4.2.19.jar:4.2.19]
  2> 	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515) [?:?]
  2> 	at java.util.concurrent.FutureTask.run(FutureTask.java:264) [?:?]
  2> 	at org.apache.solr.common.util.ExecutorUtil$MDCAwareThreadPoolExecutor.lambda$execute$0(ExecutorUtil.java:289) [solr-solrj-9.3.0-SNAPSHOT.jar:9.3.0-SNAPSHOT abc0655cce152ac6a4fda1b8632bb90667209294 [snapshot build, details omitted]]
  2> 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) [?:?]
  2> 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) [?:?]
  2> 	at java.lang.Thread.run(Thread.java:829) [?:?]