backport SOLR-17343: Live-updating Global Circuit Breakers via ClusterProperties #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Christine Poerschke <[email protected]>
Tripped soft (i.e. 'warnOnly=true') breakers are logged in a single
message for each request, whether or not there are any 'hard' breakers
that will ultimately block the request from proceeding.
Circuit breakers are "hard" by default, but may be put into warn-only
mode by:
- adding a `<bool name="warnOnly">true</bool>` setting under the
`<circuitBreaker/>` tag for collection-level CB's.
- adding a 'warnonly'-suffixed envvar/sysprop for "global" CB's.
(e.g. `SOLR_CIRCUITBREAKER_QUERY_MEM_WARNONLY=true`)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR backports
SOLR-17343: Live-updating Global Circuit Breakers via ClusterProperties, as well asSOLR-16974andSOLR-17277, two PRs thatSOLR-17343depend on.There are some changes that are not direct cherry-picks:
EnvUtils.javaandEnvToSyspropMappings.propertiesfromSOLR-17277commit - these were added in a different large PR, and I didn't want to cherry pick the whole thing. The rest of it will be pulled in when we merge with 9.4+CircuitBreakerManager.java- this is not being used by us currently and is deleted from main. I removed it since it isn't compatible with these changes.