Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T gamma bama jama #521

Merged
merged 11 commits into from
May 1, 2024
Merged

T gamma bama jama #521

merged 11 commits into from
May 1, 2024

Conversation

ckormanyos
Copy link
Collaborator

Finally PR-ing tgamma() at $128$ bits. With one test and a few TODOs. But let's see how CI cycles...

This PR is also interested in the bug fix for #520

@ckormanyos
Copy link
Collaborator Author

Hi Matt (@mborland) tgamma() at 128 bit is looking good. I added a few more tests and its cycling now. If I end up merging this, then we need to replace my homegrown impls of fma() with the real one as soon as #520 gets fixed as well.

Copy link

codecov bot commented May 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.7%. Comparing base (b2798ed) to head (c2b3312).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop    #521     +/-   ##
=========================================
- Coverage     98.7%   98.7%   -0.0%     
=========================================
  Files          181     181             
  Lines        11476   11507     +31     
=========================================
+ Hits         11326   11352     +26     
- Misses         150     155      +5     
Files Coverage Δ
...de/boost/decimal/detail/cmath/impl/lgamma_impl.hpp 75.0% <ø> (ø)
...decimal/detail/cmath/impl/taylor_series_result.hpp 100.0% <100.0%> (ø)
...de/boost/decimal/detail/cmath/impl/tgamma_impl.hpp 100.0% <100.0%> (ø)
include/boost/decimal/detail/cmath/tgamma.hpp 100.0% <100.0%> (ø)
test/test_tgamma.cpp 99.2% <100.0%> (+0.2%) ⬆️

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2798ed...c2b3312. Read the comment docs.

@ckormanyos
Copy link
Collaborator Author

Hi Matt (@mborland) I'm going to go ahead and merge this one to get the ball rolling again. There are some local impls of fma() that I'll remove when develop has the 128-bit fma() fix.

@ckormanyos ckormanyos merged commit 94c0413 into develop May 1, 2024
61 checks passed
@ckormanyos ckormanyos deleted the t_gamma_bama_jama branch May 1, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants