Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make uint128 public since we return in a few places to the user #822

Merged
merged 2 commits into from
Jan 24, 2025

Conversation

mborland
Copy link
Member

Closes: #817

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.9%. Comparing base (437d912) to head (f7880fe).
Report is 9 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop    #822     +/-   ##
=========================================
- Coverage     98.9%   98.9%   -0.0%     
=========================================
  Files          230     230             
  Lines        17055   17056      +1     
  Branches      1808    1808             
=========================================
  Hits         16864   16864             
- Misses         191     192      +1     
Files with missing lines Coverage Δ
include/boost/decimal/bid_conversion.hpp 100.0% <100.0%> (ø)
test/test_big_uints.cpp 100.0% <100.0%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 437d912...f7880fe. Read the comment docs.

@mborland mborland merged commit f51da45 into develop Jan 24, 2025
75 checks passed
@mborland mborland deleted the 817 branch January 24, 2025 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make uint128 a non-detail value since it can be returned to the user
1 participant