Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

64 bit add and sub #872

Merged
merged 7 commits into from
Feb 20, 2025
Merged

64 bit add and sub #872

merged 7 commits into from
Feb 20, 2025

Conversation

mborland
Copy link
Member

Consolidates the add and sub code while also applying optimization used for 32-bit case

Copy link

codecov bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.9%. Comparing base (3edf5fc) to head (82ea4f2).
Report is 8 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop    #872     +/-   ##
=========================================
- Coverage     98.9%   98.9%   -0.0%     
=========================================
  Files          233     233             
  Lines        16786   16779      -7     
  Branches      1801    1799      -2     
=========================================
- Hits         16586   16578      -8     
- Misses         200     201      +1     
Files with missing lines Coverage Δ
include/boost/decimal/decimal64.hpp 99.0% <100.0%> (-<0.1%) ⬇️
include/boost/decimal/decimal64_fast.hpp 98.0% <100.0%> (+0.1%) ⬆️
include/boost/decimal/detail/add_impl.hpp 100.0% <100.0%> (ø)
include/boost/decimal/detail/sub_impl.hpp 90.5% <ø> (-4.9%) ⬇️
test/benchmarks.cpp 100.0% <ø> (ø)
test/random_decimal64_math.cpp 100.0% <100.0%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3edf5fc...82ea4f2. Read the comment docs.

@mborland mborland merged commit d625b19 into develop Feb 20, 2025
75 checks passed
@mborland mborland deleted the 64_bit_add branch February 20, 2025 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant