Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for odometry message before setting manual datum so that the base and world frame names can be set. #821

Merged
merged 3 commits into from
Jul 27, 2023

Conversation

tgreier
Copy link
Contributor

@tgreier tgreier commented Jun 22, 2023

Issue #820

Add cfg params for default world and baselink frame names in the case where a manual datum is being used.
Otherwise, there is a race condition where if the transform callback runs before the odom callback, then the reference frame names are not set, and the navsat_transform will publish incorrect transforms for cartesian<->world frames.

@tgreier tgreier changed the title Added configuration params for default frame names Wait for odometry message before setting manual datum so that the base and world frame names can be set. Jun 26, 2023
src/navsat_transform.cpp Outdated Show resolved Hide resolved
@ayrton04 ayrton04 merged commit 65d6977 into cra-ros-pkg:foxy-devel Jul 27, 2023
@ayrton04
Copy link
Collaborator

Thanks!

@tgreier
Copy link
Contributor Author

tgreier commented Sep 19, 2023

@ayrton04 How do you manage merging changes from foxy-devel into the master branch or other later branches (such as humble)? Do I do that manually by creating pull requests for each branch?

@ayrton04
Copy link
Collaborator

I'd normally cherry-pick them, but as we're deprecating this package soon, it'll be helpful if you'd just open PRs against each. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants