Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistency between Chrome and Firefox #182

Merged
merged 3 commits into from
Jan 14, 2025

Conversation

marcospassos
Copy link
Member

Summary

  • Updated the locale in the fromZonedDate method from 'en-US' to 'sv-SE' to ensure correct date formatting.
  • Modified the regex pattern in the fromZonedDate method to match the new date format.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@marcospassos marcospassos added the bug Something isn't working label Jan 14, 2025
@marcospassos marcospassos changed the title Fix formatting inconsistency between Chrome and Firefox Fix inconsistency between Chrome and Firefox Jan 14, 2025
Copy link

codeclimate bot commented Jan 14, 2025

Code Climate has analyzed commit 50c7473 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 100.0% (0.0% change).

View more on Code Climate.

@marcospassos marcospassos merged commit 6bf6b45 into master Jan 14, 2025
5 checks passed
@marcospassos marcospassos deleted the fix-browser-inconsistency branch January 14, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant