-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create containerattached
Cluster
resource
#485
Create containerattached
Cluster
resource
#485
Conversation
/test-examples="examples/containerattached/v1beta1/cluster.yaml" |
Hi @RedbackThomson, Thank you for your effort to add this resource. We currently do not have a mechanism to automatically test this resource. Therefore, we need to test manually and add manual intervention annotation to the resource YAML file. Let me explain the manual test steps:
After providing the tricky parameters in this way, let me share with you an example with manual intervention below:
|
Added manual intervention annotation to the example. I was able to test the resource with an existing attached cluster, and saw that it was able to reconcile the status into the resource. It looks like it works 👍🏼 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @RedbackThomson, it seems that there are uncommitted changes after make generate
, could you please run make generate
and commit all changes?
And it would be great if you could add how you tested it in the PR description.
3d2cf5c
to
c477978
Compare
@turkenf Looks like it needed a rebase and regenerate. Fixed up that commit and force pushed. Added my test methodology to the description, with an example manifest. |
Description of your changes
Adds the
google_container_attached_cluster
resource to a newly createdcontainerattached
groupI have:
make reviewable
to ensure this PR is ready for review.backport release-x.y
labels to auto-backport this PR if necessary.How has this code been tested
I was able to e2e test this by creating an EKS cluster with an OIDC issuer (using the XEKS composition from
configuration-aws-eks
). I copied the output OIDC Issuer URL intooidcConfig.issuerUrl
, set theplatformVersion
to the newest version supported for the 1.28 Kubernetes cluster, and updated thedistribution
toeks
.Here is a redacted version of the manifest I applied: