Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix assertions after gherkin update #205

Merged
merged 3 commits into from
Feb 23, 2022
Merged

Fix assertions after gherkin update #205

merged 3 commits into from
Feb 23, 2022

Conversation

ilslv
Copy link
Member

@ilslv ilslv commented Feb 16, 2022 •
edited by tyranron
Loading

Part of cucumber-rs/gherkin#33

Synopsis

After fixes inside gherkin crate we need to also fix tests here

Solution

Fix assertions.

Checklist

  • Created PR:
    • In draft mode
    • Name contains Draft: prefix
    • Name contains issue reference
    • Has assignee
  • Documentation is updated (if required)
  • Tests are updated (if required)
  • Changes conform code style
  • CHANGELOG entry is added (if required)
  • FCM (final commit message) is posted
    • and approved
  • Review is completed and changes are approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • Draft: prefix is removed
    • All temporary labels are removed

@ilslv ilslv added the enhancement Improvement of existing features or bugfix label Feb 16, 2022
@ilslv ilslv added this to the 0.12.0 milestone Feb 16, 2022
@ilslv ilslv self-assigned this Feb 16, 2022
ilslv
ilslv commented Feb 16, 2022
View reviewed changes
src/feature.rs
@@ -170,7 +170,7 @@ fn expand_scenario(
// This is done to differentiate `Hash`es of
// scenario outlines with the same examples.
expanded.position = position;
expanded.position.line += id + 1;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is done, because original intention was to point expanded Scenario line onto exact cell from Examples. For this we need to add 2 lines: one for Examples: line itself and the header of the table.

@ilslv
Copy link
Member Author

ilslv commented Feb 16, 2022 •
edited by tyranron
Loading

FCM

Fix assertions after updating `gherkin` to 0.11.2 version (#205, cucumber-rs/gherkin#33)

@tyranron
Copy link
Member

@ilslv gherkin 0.11.2 has been released.

@tyranron tyranron self-requested a review February 23, 2022 15:27
@tyranron tyranron merged commit b25fa32 into main Feb 23, 2022
@tyranron tyranron deleted the fix-tests branch February 23, 2022 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyranron tyranron tyranron approved these changes

Assignees

@ilslv ilslv

Labels
enhancement Improvement of existing features or bugfix
Projects
None yet
Milestone
0.12.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ilslv @tyranron