Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perepare release to PyPi #243

Closed
wants to merge 1 commit into from
Closed

Conversation

elchupanebrej
Copy link
Contributor

🤔 What's changed?

Fixup pyproject.toml to conform with the existing release

⚡️ What's your motivation?

I want to have PyPi released continuously.

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, documentation etc. without changing behaviour)

📋 Checklist:


This text was originally generated from a template, then edited by hand. You can modify the template here.

@codecov-commenter
Copy link

codecov-commenter commented Dec 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (701105a) 91.17% compared to head (fda5278) 91.17%.
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #243   +/-   ##
=======================================
  Coverage   91.17%   91.17%           
=======================================
  Files           2        2           
  Lines          34       34           
=======================================
  Hits           31       31           
  Misses          3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mpkorstanje mpkorstanje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a release process setup through Github actions. This means that in essence, we only have to set the version number for each implementation and push a git tag (all automated through https://github.com/cucumber/polyglot-release).

So to get the release process working again, I suppose you would have to take your manual instructions and convert them into a Github action.

As a template you could use this commit b00f19a in which I disabled the python release process (#213).

@elchupanebrej elchupanebrej force-pushed the main branch 3 times, most recently from 35b1ae4 to 17026be Compare January 10, 2024 19:10
@mpkorstanje
Copy link
Contributor

mpkorstanje commented Jan 10, 2024

Heya. @brasmusson has been setting up publishing to PyPi using trusted publishers. This is the ideal solution.

Apologies for changing the desired solution. Things is are changing atypically quick.

@luke-hill
Copy link
Contributor

@elchupanebrej - This probably should have been looked at a while ago. Looking at the 2 linked by @mpkorstanje - it seems as though there is a specific action that is used called pypa/gh-action-pypi-publish@release/v1 - Can we try use that here for standardisation?

@mpkorstanje mpkorstanje self-requested a review October 2, 2024 12:36
@luke-hill
Copy link
Contributor

No longer required

@luke-hill luke-hill closed this Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants