Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid NaN percentage passed when nothing ran #363

Merged
merged 4 commits into from
Jan 23, 2025
Merged

Avoid NaN percentage passed when nothing ran #363

merged 4 commits into from
Jan 23, 2025

Conversation

davidjgoss
Copy link
Contributor

πŸ€” What's changed?

Don't attempt to do a 0 / 0 percentage calculation if no test cases ran.

⚑️ What's your motivation?

Fixes #362.

🏷️ What kind of change is this?

  • πŸ› Bug fix (non-breaking change which fixes a defect)

πŸ“‹ Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

Copy link

netlify bot commented Jan 23, 2025

βœ… Deploy Preview for cucumber-react-preview ready!

Name Link
πŸ”¨ Latest commit 007746e
πŸ” Latest deploy log https://app.netlify.com/sites/cucumber-react-preview/deploys/67923ae07398290008f57b67
😎 Deploy Preview https://deploy-preview-363--cucumber-react-preview.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@davidjgoss davidjgoss changed the title Nan status Avoid NaN percentage passed when nothing ran Jan 23, 2025
Copy link

netlify bot commented Jan 23, 2025

βœ… Deploy Preview for cucumber-react-preview ready!

Name Link
πŸ”¨ Latest commit 84a59c9
πŸ” Latest deploy log https://app.netlify.com/sites/cucumber-react-preview/deploys/67923b5a7ec7b100080ea3f1
😎 Deploy Preview https://deploy-preview-363--cucumber-react-preview.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@davidjgoss davidjgoss marked this pull request as ready for review January 23, 2025 13:06
@davidjgoss davidjgoss merged commit 31723da into main Jan 23, 2025
6 checks passed
@davidjgoss davidjgoss deleted the nan-status branch January 23, 2025 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0/0 tests passed shows overall as NaN%
1 participant