Install bash scripts improvements #413
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
guest20
reviewed
Nov 29, 2024
install.sh
Outdated
| @@ -1,36 +1,41 @@ | |||
| #!/bin/bash | |||
| # Check if the script is running as root | |||
| [ "$EUID" -eq 0 ] || exec sudo bash "$0" "$@" | |||
There was a problem hiding this comment.
- I'm pretty sure the os detection and the wget really don't benefit from being run as root.
- Also, some bsd machines dont have sudo by default.
It might make more sense to just wrap the sudo around autorestic install... and maybe only after checking there is a sudo in the first place?
There was a problem hiding this comment.
Hi, I made some changes to handle elevation to root with sudo or su, and only commands that need to write to /usr/local/bin are executed as root.
guest20
reviewed
Dec 3, 2024
| [ "$EUID" -eq 0 ] || exec sudo bash "$0" "$@" | ||
| # Initialize the elevated variable to ensure we can run commands as root | ||
| if [ "$EUID" -eq 0 ]; then | ||
| elevated="bash -c" # No need for sudo or su if running as root |
There was a problem hiding this comment.
elevated=""
Setting it to the empty string means it just goes away - setting it to bash means a whole new shell.
guest20
reviewed
Dec 3, 2024
install.sh
Outdated
| bzip2 -cd "${TMP_FILE}.bz2" > "${OUT_FILE}" | ||
| chmod +x ${OUT_FILE} | ||
| rm "${TMP_FILE}.bz2" | ||
| $elevated "bzip2 -cd ${TMP_FILE}.bz2 > ${OUT_FILE}" |
There was a problem hiding this comment.
Your redirect (>)won't happen as root
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, while installing autorestic (thank you for the amazing projects) i took the liberty to do some changes to the installation script. If it's ran as no root user it will leverage the sudo command to run it in elevated mode, the if statement changed with case and other minors changes. I hope it can be of use.
Thanks