Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Note for CI missing docs that pnpm isn't supported #5881

Closed
wants to merge 1 commit into from
Closed

docs: Note for CI missing docs that pnpm isn't supported #5881

wants to merge 1 commit into from

Conversation

bmulholland
Copy link

@bmulholland bmulholland commented Jul 26, 2024

See also #5880

Copy link

netlify bot commented Jul 26, 2024

👷 Deploy request for cypress-docs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 9aa021b

@cypress-app-bot
Copy link
Collaborator

@jennifer-shehane
Copy link
Member

@MikeMcC399 thoughts?

@MikeMcC399
Copy link
Contributor

@jennifer-shehane

This PR was proposing to make changes to https://docs.cypress.io/guides/continuous-integration/introduction#Caching.
The section does not cover specifics for the Cypress JavaScript GitHub Action (cypress-io/github-action) and is intended for general use.

  • There was never any restriction on caching across builds with pnpm without cypress-io/github-action.

  • The temporary restriction on manually caching the pnpm store across builds was lifted with the resolution of Provide pnpm workflow caching without action enhancement github-action#1227. The action cypress-io/github-action in any case caches the Cypress binary and the npm cache across builds and this cannot be disabled.

I suggest to close this PR.

@bmulholland bmulholland deleted the patch-3 branch August 1, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants