Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: configure adapter tests #15

Merged
merged 44 commits into from
Nov 27, 2023
Merged

test: configure adapter tests #15

merged 44 commits into from
Nov 27, 2023

Conversation

irrationnelle
Copy link
Contributor

@irrationnelle irrationnelle commented Aug 22, 2023 •
edited
Loading

I've set up the essential tests to verify the specifications of Plantae.

Please check for comments labeled with the 'FIXME' tag.

You can also review the commit history in the origin/test/add-tests branch.

This current branch was created specifically to prevent merge conflicts.

@irrationnelle irrationnelle added the documentation Improvements or additions to documentation label Aug 22, 2023
@irrationnelle irrationnelle requested a review from orionmiz August 22, 2023 07:49
@irrationnelle irrationnelle self-assigned this Aug 22, 2023
@changeset-bot
Copy link

changeset-bot bot commented Aug 22, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: fbcbfb4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@irrationnelle irrationnelle requested a review from orionmiz August 22, 2023 08:28
@orionmiz orionmiz changed the title Prepare basic tests for each middleware test: configure adapter tests Aug 22, 2023
@orionmiz
Copy link
Member

Note nodeLinker is set to node-modules temporarily due to the pnp issue.

irrationnelle
irrationnelle commented Nov 20, 2023
View reviewed changes
Copy link
Contributor Author

@irrationnelle irrationnelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p3.

I would like to suggest that you could try to 'given / when / then' test.

IMHO, I can not recognize that certain line is belong to between 'given' and 'when'.

.github/workflows/ci.yml Show resolved Hide resolved
packages/plantae/src/axios/createAxiosInterceptors.spec.ts Outdated Show resolved Hide resolved
@irrationnelle
Copy link
Contributor Author

@orionmiz

Tests are readable due to the well-implemented colocation of specifications.
I would accept all the changes. Looks good to me.
You should merge this PR that I initially created.

@orionmiz orionmiz enabled auto-merge (squash) November 27, 2023 17:21
@orionmiz orionmiz disabled auto-merge November 27, 2023 23:27
@orionmiz orionmiz merged commit bd28843 into main Nov 27, 2023
3 checks passed
@orionmiz orionmiz deleted the test/basic branch November 27, 2023 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orionmiz orionmiz orionmiz approved these changes

Assignees

@irrationnelle irrationnelle

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@irrationnelle @orionmiz