Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update docker examples (Fixes #638) #818

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

arky
Copy link
Contributor

@arky arky commented Feb 9, 2025

Update docker examples, fix hello-world.ts comands and fix docker host examples

Fixes #638

Copy link
Collaborator

@yohamta yohamta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! Thanks a lot for resolving the issue 🚀🚀🚀

@yohamta yohamta merged commit eb7944f into dagu-org:main Feb 10, 2025
4 checks passed
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.89%. Comparing base (e747cef) to head (9fcf664).
Report is 9 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #818      +/-   ##
==========================================
+ Coverage   55.55%   55.89%   +0.34%     
==========================================
  Files          73       73              
  Lines        7904     7920      +16     
==========================================
+ Hits         4391     4427      +36     
+ Misses       3134     3112      -22     
- Partials      379      381       +2     

see 22 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e747cef...9fcf664. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid example of docker executor with volumes
2 participants