Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add git tags to dagu version (Fixes #816) #822

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

arky
Copy link
Contributor

@arky arky commented Feb 10, 2025

Fetch git tag and appended to LDFLAGS in Makefile.

Improve dagu version command line output with github tags.

Fixes #816

@arky arky requested a review from yohamta February 10, 2025 14:38
Copy link
Contributor Author

@arky arky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The output now shows complete build version

$ .local/bin/dagu version
v1.16.0-23-gc831612d6-250210213530

Copy link
Collaborator

@yohamta yohamta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! Thank you so much! 🚀🚀🚀

@yohamta yohamta merged commit 83bcb60 into dagu-org:main Feb 11, 2025
4 checks passed
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.89%. Comparing base (c831612) to head (6811390).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #822      +/-   ##
==========================================
- Coverage   55.93%   55.89%   -0.04%     
==========================================
  Files          73       73              
  Lines        7920     7920              
==========================================
- Hits         4430     4427       -3     
- Misses       3110     3112       +2     
- Partials      380      381       +1     

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c831612...6811390. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve dagu version command line output
2 participants