Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding sample data #149

Merged
merged 12 commits into from
Oct 23, 2024
Merged

Conversation

chrishavlin
Copy link
Collaborator

Aim is to close #60

Initial push is just the skeleton for getting a single sample dataset into the napari GUI

@chrishavlin chrishavlin added the enhancement New feature or request label Oct 22, 2024
@chrishavlin
Copy link
Collaborator Author

Screenshot 2024-10-22 at 12 36 03 PM

screenshot from the initial skeleton (it does actually load, too!)

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.60%. Comparing base (44635b2) to head (1bb93d0).
Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #149      +/-   ##
==========================================
+ Coverage   99.58%   99.60%   +0.01%     
==========================================
  Files          32       37       +5     
  Lines        2669     2799     +130     
==========================================
+ Hits         2658     2788     +130     
  Misses         11       11              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chrishavlin
Copy link
Collaborator Author

chrishavlin commented Oct 22, 2024

Latest push adds a new taskipy task that will generate all the necessary code to load a given sample. To do:

  • add tests
  • add documentation
  • decide on what sample datasets to use
  • add developer docs for updating enabled datasets

@chrishavlin
Copy link
Collaborator Author

example of current state:

yt-napari-sample-data.mp4

@chrishavlin
Copy link
Collaborator Author

thinking that maybe the options in the browser should indicate which field will be loaded

@chrishavlin chrishavlin added this to the v0.6.0 milestone Oct 22, 2024
@chrishavlin
Copy link
Collaborator Author

oh, could add some of the smaller timeseries too.

@chrishavlin
Copy link
Collaborator Author

not totally set on the current list of sample data, but can always add more, so going to merge...

@chrishavlin chrishavlin merged commit c132a66 into data-exp-lab:main Oct 23, 2024
15 checks passed
@chrishavlin chrishavlin deleted the load_sample_data branch October 23, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sample data
1 participant