Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pyproject.toml #7033

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

Add pyproject.toml #7033

wants to merge 8 commits into from

Conversation

loadams
Copy link
Collaborator

@loadams loadams commented Feb 13, 2025

  • Test all build cases this needs to support.
  • Test Windows builds/support.
  • Confirm pre-compiling ops - works with --no-build-isolation
  • Test commit hashes are added to dev builds

The main goal of this effort is to become compliant with the coming changes to pip in 25.1 listed here which will break editable installs. Future PRs will fully move from setup.py to pyproject.toml

Fixes: #7031

pyproject.toml Outdated Show resolved Hide resolved
@jeffra
Copy link
Collaborator

jeffra commented Feb 14, 2025

@mrwyattii we just went through some of this with arctic training. If it’s helpful @loadams let’s discuss on slack a bit. There’s a ton that’s currently happening in setup.py, this could be a big lift? But I agree, needs to happen!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix - Update DeepSpeed to be PEP517 compliant, update to pyproject.toml
3 participants