Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add check for whether appendOnly table feature is supported or enabled #664

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

OussamaSaoudi
Copy link
Collaborator

@OussamaSaoudi OussamaSaoudi commented Jan 28, 2025

What changes are proposed in this pull request?

This PR adds two functions to TableConfiguration:

  1. check whether appendOnly table feature is supported
  2. check whether appendOnly table feature is enabled

It also enabled writes on tables with AppendOnly writer feature.

How was this change tested?

I check that write is supported on Protocol with WriterFeatures::AppendOnly.

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 42.10526% with 11 lines in your changes missing coverage. Please review.

Project coverage is 84.04%. Comparing base (eedfd47) to head (6069d4d).

Files with missing lines Patch % Lines
kernel/src/table_configuration.rs 0.00% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #664      +/-   ##
==========================================
- Coverage   84.09%   84.04%   -0.06%     
==========================================
  Files          77       77              
  Lines       17805    17817      +12     
  Branches    17805    17817      +12     
==========================================
+ Hits        14973    14974       +1     
- Misses       2117     2128      +11     
  Partials      715      715              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the breaking-change Change that will require a version bump label Jan 28, 2025
Copy link
Collaborator

@scovich scovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is something delta-rs needs right away, given that we don't have kernel code using it yet?

@OussamaSaoudi
Copy link
Collaborator Author

Hey @scovich sorry this message slipped! This check is going to be used on the write path soon ™️. Perhaps I'll mark it merge-hold until the write path infra is built.

@OussamaSaoudi OussamaSaoudi added the merge hold Don't allow the PR to merge label Jan 30, 2025
@OussamaSaoudi OussamaSaoudi removed the merge hold Don't allow the PR to merge label Feb 3, 2025
@OussamaSaoudi
Copy link
Collaborator Author

@scovich Ah I was missing one change. Added appendOnly to the set of writer features. The TableConfigurationCheck will be useful in the future when we add the ability to remove files. In that case, we'd have to assert that it's not enabled.

Removing the merge-hold

@OussamaSaoudi OussamaSaoudi marked this pull request as ready for review February 3, 2025 23:05
@OussamaSaoudi OussamaSaoudi removed the breaking-change Change that will require a version bump label Feb 3, 2025
Copy link
Collaborator

@zachschuermann zachschuermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

kernel/src/table_features/mod.rs Outdated Show resolved Hide resolved
kernel/src/table_configuration.rs Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants