Bug Fix: changing maxPageListLength from 3 to 7 to match CMS

[moanu404]

Description

Currently in prod CMS this field is set to 7 but in next-build it was set and hardcoded to 3, This PR is changing this in next-build to 7 to better match what is currently in prod, and adding it as a constant so in future we only have to change it in one place instead of a few as we scale this thing out.

Ticket

Closes to #19849

Developer Task

Tasks

Preview Give feedback

1. PR submitted against the main branch of next-build.
2. Link to the issue that this PR addresses (if applicable).
3. Define all changes in your PR and note any changes that could potentially be breaking changes.
4. PR includes steps to test your changes and links to these changes in the Tugboat preview (if applicable).
5. Provided before and after screenshots of your changes (if applicable).
6. Alerted the #accelerated-publishing Slack channel to request a PR review.
7. You understand that once approved, you are responsible for merging your changes into main. (Note that changes to main will move automatically into production.)

Testing Steps

For local testing load up
http://localhost:3999/boston-health-care/news-releases/
http://localhost:3999/boston-health-care/stories/ (although this one does not have enough pages to see a difference)
and ensure that at the bottom the component upon inspection is like

QA steps

Check the footer, ensure it works

Screenshots

Before:

After:

Is this PR blocked by another PR?

• Add the DO NOT MERGE label
• Add links to additional PRs here:

Reviewer

Reviewing a PR

This section lists items that need to be checked or updated when making changes to this repository.

Standard Checks

Tasks

Preview Give feedback

1. Code Quality: Readabilty, Naming Conventions, Consistency, Reusability
2. Test Coverage: 80% coverage
3. Functionality: Change functions as expected with no additional bugs
4. Performance: Code does not introduce performance issues
5. Documentation: Changes are documented in their respective README.md files
6. Security: Packages have been approved in the TRM

Merging an Approved Layout

When merging a layout, you must ensure that the content type has been turned on for next-build inside the CMS. This CMS flag must be turned on for editors to preview their work using the next build preview server.

Resource types (layouts) that have not been approved by design should NOT be pushed to production. Ensure that slug.tsx does not include your resource type if it is not approved.

The status of layouts should be kept up to date inside templates.md. This includes QA progress, development progress, etc. A link should be provided for where testing can occur.

Merging a Non-Approved Layout

Your new resource type should not be included inside slug.tsx. Items added here will go into production once merged into the main branch. It is imperative that we do not push anything live that has not been approved.

Ensure that this layout has been added to the templates.md file with the current status of the work.

[brianseek]

nice!

[brianseek]

@moanu404 this looks great to me. The only thing I notice is that prod shows 5 pages rather than 8, not sure if this is the new desired amount or if it is supposed to match prod. https://www.va.gov/boston-health-care/news-releases/

[moanu404]

@moanu404 this looks great to me. The only thing I notice is that prod shows 5 pages rather than 8, not sure if this is the new desired amount or if it is supposed to match prod. https://www.va.gov/boston-health-care/news-releases/

no you are right, and great catch! I def looked at another field and stored it in my 🧠 and then ran with it

looks like the correct`maxPageListLength` seems to be 7 when i inspect it

[brianseek]

looks like the correctmaxPageListLength seems to be 7 when i inspect it

Oh that makes sense, it's 7 spaces including the last page and ...

[brianseek]

Should this get changed to 7?

[brianseek]

Looks great!