VACMS-20426: Corrects forms audit 'Form Administration' allowed values

[dsasser]

Description

Relates to #20426

Testing done

Manually.

Screenshots

QA steps

Expected Form Administration Values:

VACO
NCA
VBA
VHA
OCTO

Test Audit View

• Login as 'QA Content Editor'
• Visit the Audit page
• Expand the 'Form Administration' filter
• Confirm there is no 'VAMC Facilities' option
• Confirm the options match the expected Form Administration values from above
• Select 'VACO' from the 'Form Administration' filter and click the 'Filter' button
• Confirm you see only 'VACO' in the 'Forms Administration' column of the report
• Click the 'Download CSV' button
• Confirm the 'va_form_audit.csv' file is downloaded
• Open the CSV and confirm that you see only 'VACO' in the 'Forms Administration' column

Test VA Forms View for regressions

• Visit the VA Forms page
• Expand the 'Form Administration' filter
• Confirm there is no 'VAMC Facilities' option
• Confirm the options match the expected Form Administration values from above

Test Changed Filename View for regressions

• Visit Changed Filename
• Expand the 'Form Administration' filter
• Confirm there is no 'VAMC Facilities' option
• Confirm the options match the expected Form Administration values from above

Test Changed Title View for regressions

• Visit Changed Title
• Expand the 'Form Administration' filter
• Confirm there is no 'VAMC Facilities' option
• Confirm the options match the expected Form Administration values from above

Test New/Deleted Forms for regressions

• Visit New/Deleted Forms
• Expand the 'Form Administration' filter
• Confirm there is no 'VAMC Facilities' option
• Confirm the options match the expected Form Administration values from above

Definition of Done

• Documentation has been updated, if applicable.
• Tests have been added if necessary.
• Automated tests have passed.
• Code Quality Tests have passed.
• Acceptance Criteria in related issue are met.
• Manual Code Review Approved.
• If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

• CMS Team
• Public websites
• Facilities
• User support
• Accelerated Publishing

[github-actions]

Checking composer.lock changes...

[github-actions]

Checking composer.lock changes...

[omahane]

I logged in first as QA Content Publisher and also as myself. I found that I could filter the online report using "VACO", but the download of the CSV resulted in a blank download. I think the CSV export display also needs to be changed.

[github-actions]

Checking composer.lock changes...

[omahane]

Everything checks out!

[github-actions]

Checking composer.lock changes...

[va-cms-bot]

Cypress Accessibility Violations

/test-data-ipsa

ID: button-name
Impact: critical
Tags: cat.name-role-value, wcag2a, wcag412, section508, section508.22.a, TTv5, TT6.a, EN-301-549, EN-9.4.1.2, ACT
Description: Ensure buttons have discernible text
Help: Buttons must have discernible text
Nodes:

• HTML: <button class="proofing-element-help" role="tooltip" data-proofing-help-title="About 'Page introduction' field" data-proofing-help="Add an introduction that helps visitors understand if information on the page is relevant to them."> <span aria-hidden="true">i</span> </button>
  Impact: critical
  Target: .field--name-field-intro-text-limited-html > .field__label > .proofing-element-help[role="tooltip"]
  Summary: Fix any of the following:
  Element does not have inner text that is visible to screen readers
  aria-label attribute does not exist or is empty
  aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
  Element has no title attribute
  Element does not have an implicit (wrapped) <label>
  Element does not have an explicit <label>
  Element's default semantics were not overridden with role="none" or role="presentation"

• HTML: <button class="proofing-element-help" role="tooltip" data-proofing-help-title="About 'Generate a table of contents from major headings' field" data-proofing-help="By checking this box, all h2's below this point on the page will be linked with with anchor links. This helps users navigate content on very long pages. Do not check this box unless there is at least 2 h2's on the page.">
  Impact: critical
  Target: .field--name-field-table-of-contents-boolean > .field__label > .proofing-element-help[role="tooltip"]
  Summary: Fix any of the following:
  Element does not have inner text that is visible to screen readers
  aria-label attribute does not exist or is empty
  aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
  Element has no title attribute
  Element does not have an implicit (wrapped) <label>
  Element does not have an explicit <label>
  Element's default semantics were not overridden with role="none" or role="presentation"

• HTML: <button class="proofing-element-help" role="tooltip" data-proofing-help-title="About 'Main content' field" data-proofing-help="The main body of the page, which appears below the featured content."> <span aria-hidden="true">i</span> </button>
  Impact: critical
  Target: button[data-proofing-help-title="About 'Main content' field"]
  Summary: Fix any of the following:
  Element does not have inner text that is visible to screen readers
  aria-label attribute does not exist or is empty
  aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
  Element has no title attribute
  Element does not have an implicit (wrapped) <label>
  Element does not have an explicit <label>
  Element's default semantics were not overridden with role="none" or role="presentation"