Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-20308: update content-build and simplesamlphp dependencies #20539

Conversation

edmund-dunn
Copy link
Contributor

Description

Relates to #20308

Testing done

Screenshots

QA steps

What needs to be checked to prove this works?
What needs to be checked to prove it didn't break any related things?
What variations of circumstances (users, actions, values) need to be checked?

As long as this passes automated testing it should be good.

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.
  • If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

Is this PR blocked by another PR?

  • DO NOT MERGE

Does this PR need review from a Product Owner

  • Needs PO review

CMS user-facing announcement

Is an announcement needed to let editors know of this change?

  • Yes, and it's written in issue ____ and queued for publication.
    • Merge and ping the UX writer so they are ready to publish after deployment
  • Yes, but it hasn't yet been written
    • Don't merge yet -- ping the UX writer to write and queue content
  • No announcement is needed for this code change.
    • Merge & carry on unburdened by announcements

@edmund-dunn edmund-dunn linked an issue Feb 13, 2025 that may be closed by this pull request
1 task
@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 13, 2025 20:59 Destroyed
Copy link

Checking composer.lock changes...

Copy link

The number of lines changed in composer.lock exceeds the acceptable threshold.

  • Lines changed: 254
  • Threshold: 200

This is a warning only. Please review the changes and ensure that they are acceptable.

@github-actions github-actions bot added the CMS Team CMS Product team that manages both editor exp and devops label Feb 13, 2025
@edmund-dunn edmund-dunn enabled auto-merge (squash) February 13, 2025 21:24
@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 14, 2025 08:56 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 15, 2025 08:55 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 16, 2025 08:51 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 17, 2025 08:51 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 17, 2025 17:32 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 17, 2025 17:58 Destroyed
@va-cms-bot
Copy link
Collaborator

Cypress Accessibility Violations

/test-data-molestiae

ID: button-name
Impact: critical
Tags: cat.name-role-value, wcag2a, wcag412, section508, section508.22.a, TTv5, TT6.a, EN-301-549, EN-9.4.1.2, ACT
Description: Ensure buttons have discernible text
Help: Buttons must have discernible text
Nodes:

  • HTML: <button class="proofing-element-help" role="tooltip" data-proofing-help-title="About 'Page introduction' field" data-proofing-help="Add an introduction that helps visitors understand if information on the page is relevant to them."> <span aria-hidden="true">i</span> </button>
    Impact: critical
    Target: .field--name-field-intro-text-limited-html > .field__label > .proofing-element-help[role="tooltip"]
    Summary: Fix any of the following:
    Element does not have inner text that is visible to screen readers
    aria-label attribute does not exist or is empty
    aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
    Element has no title attribute
    Element does not have an implicit (wrapped) <label>
    Element does not have an explicit <label>
    Element's default semantics were not overridden with role="none" or role="presentation"

  • HTML: <button class="proofing-element-help" role="tooltip" data-proofing-help-title="About 'Generate a table of contents from major headings' field" data-proofing-help="By checking this box, all h2's below this point on the page will be linked with with anchor links. This helps users navigate content on very long pages. Do not check this box unless there is at least 2 h2's on the page.">
    Impact: critical
    Target: .field--name-field-table-of-contents-boolean > .field__label > .proofing-element-help[role="tooltip"]
    Summary: Fix any of the following:
    Element does not have inner text that is visible to screen readers
    aria-label attribute does not exist or is empty
    aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
    Element has no title attribute
    Element does not have an implicit (wrapped) <label>
    Element does not have an explicit <label>
    Element's default semantics were not overridden with role="none" or role="presentation"

  • HTML: <button class="proofing-element-help" role="tooltip" data-proofing-help-title="About 'Main content' field" data-proofing-help="The main body of the page, which appears below the featured content."> <span aria-hidden="true">i</span> </button>
    Impact: critical
    Target: button[data-proofing-help-title="About 'Main content' field"]
    Summary: Fix any of the following:
    Element does not have inner text that is visible to screen readers
    aria-label attribute does not exist or is empty
    aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
    Element has no title attribute
    Element does not have an implicit (wrapped) <label>
    Element does not have an explicit <label>
    Element's default semantics were not overridden with role="none" or role="presentation"

@edmund-dunn edmund-dunn merged commit 29a3e1b into main Feb 17, 2025
19 checks passed
@edmund-dunn edmund-dunn deleted the 20308-bug-content-build-updates-are-not-being-added-to-cms-composer branch February 17, 2025 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMS Team CMS Product team that manages both editor exp and devops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: content-build updates are not being added to CMS composer
3 participants