-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pre-commit.ci] pre-commit autoupdate #184
Conversation
Thanks for looking into the failures! I'm busy these days and wouldn't have time to look at any of this until this weekend. FWIW the typing error looks to be caused by the fix to my bug report pypa/pyproject-metadata#126, so we have a situation where different versions of (also |
Yeah, fair comment … I'll try and split those up when I next get the chance. I had a few brief moments at work yesterday to quietly slip that in but my quick fix doesn't appear to have solved much (
Had the bot done this the day before I might've dealt with it then because it was a public holiday here in Queensland (King's Birthday long weekend) so I would have had the time, but this week has been a busy one. Might be able to get to it on Friday evening (Australia/Brisbane; early Friday morning US/Pacific). |
If I correctly understood what's going on, the failure would happen on main as well: it was caused by the release of a new backward-incompatible version (0.8.1 I think) of pyproject-metadata. So no need to base the new branch on this one. It only showed up here because this was the first time our pre-commit CI workflow ran since that version of pyproject-metadata got released. It might not be a bad idea to add a scheduled run of our CI on |
Yeah, that's not a bad idea… I do the same thing at work for that reason. Weekly re-build of everything to ensure nothing silently breaks. I got fed up of seeing builds that were 'green', and turn 'red' the moment someone touches them because dependencies shifted. |
f1e3d04
to
0863153
Compare
0863153
to
0150497
Compare
After #185, I get a sneaking suspicion we may actually be able to use the latest |
1354e96
to
228fd96
Compare
228fd96
to
d610b83
Compare
I'll get back to this soon 😅 life got in the way.... |
updates: - [github.com/pre-commit/pre-commit-hooks: v4.6.0 → v5.0.0](pre-commit/pre-commit-hooks@v4.6.0...v5.0.0) - [github.com/astral-sh/ruff-pre-commit: v0.0.233 → v0.9.4](astral-sh/ruff-pre-commit@v0.0.233...v0.9.4) - [github.com/pre-commit/mirrors-mypy: v1.11.2 → v1.14.1](pre-commit/mirrors-mypy@v1.11.2...v1.14.1) - [github.com/psf/black: 24.8.0 → 25.1.0](psf/black@24.8.0...25.1.0) - [github.com/rhysd/actionlint: v1.7.1 → v1.7.7](rhysd/actionlint@v1.7.1...v1.7.7) - [github.com/igorshubovych/markdownlint-cli: v0.41.0 → v0.44.0](igorshubovych/markdownlint-cli@v0.41.0...v0.44.0)
d610b83
to
ec3b72d
Compare
I'm a little tempted to just close this PR and let the bot start from scratch on a new branch next time.... |
Yeah, might be a thought… we'll close for now and see what it comes up with in a few weeks time. |
Thanks! I deleted the branch, too, otherwise the bot might just try to reopen this. |
updates: