Add more constructors for NonEmptyList #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runeflobakk
force-pushed
the
nonemptylist-more-constructors
branch
from
41a413e to
2f83d48
Compare
More complete set of constructor variants from both lists and arrays, and being consistent with copying or not.
runeflobakk
force-pushed
the
nonemptylist-more-constructors
branch
from
2f83d48 to
52e306d
Compare
evenh
approved these changes
Jun 18, 2021
Co-authored-by: Even Holthe <[email protected]>
Documentation for the "unsafe" constructors for NonEmptyList were incorrectly stating the list/array may be empty, but it is more correct to say that they are assumed to be non-empty, and an exception is thrown in the case of it being empty.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More complete set of constructors from both lists and arrays. The constructors are named consistently whether they copy the element references of the source or not.
Interestingly, japicmp reports adding new static methods to an interface as a binary incompatible change, but I suspect this is a false positive, since it's identified as
METHOD_NEW_DEFAULT, and a static methods is not the same as a default method. I have asked about this here: siom79/japicmp#289